They don't really qualify as the worst ever, but some of the worst contracts in the NBA have passed through the Knicks roster recently: Allan Houston, Jalen Rose, Stephon Marbury, Jerome James, Q Richardson, Zach Randolph, Steve Francis, Eddy Curry and Jamal Crawford.
It must be your I hate New York bias because Houston and James are the only ones there that are horrible. Marbury wasn't signed by the Knicks and was a big time PG when he signed with Phoenix. Same with Francis with Houston and he only spent like a year and a half with New York. Z-Bo averages 20 and 10 each year and deserves his contract. Centers get mad money nowadays so Curry getting 9 million a year ain't bad at all. Jamal Crawford makes like 7-8 million a year, same with Q, and honestly that's not bad either the way people are handing out contracts.